Skip to content

Extend progress notification support#163

Merged
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
Tyler-R-Kendrick:progress-tokens
Apr 1, 2025
Merged

Extend progress notification support#163
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
Tyler-R-Kendrick:progress-tokens

Conversation

@Tyler-R-Kendrick
Copy link
Copy Markdown
Contributor

  • Added implementation of progress notifications for server and client default handlers.
  • Corrected request type hierarchy to provide "meta" parameters from base request to support progress.
  • Added IProgress type to sampling handler.

@Tyler-R-Kendrick Tyler-R-Kendrick marked this pull request as ready for review March 31, 2025 17:28
@Tyler-R-Kendrick
Copy link
Copy Markdown
Contributor Author

This is to address the issue I opened:
#111

@stephentoub
Copy link
Copy Markdown
Contributor

Thanks, @Tyler-R-Kendrick. Can you please take a look at the latest in main, and in particular the progress changes that were merged in #145? I expect this PR will need to be changed a bit based on that.

Comment thread src/ModelContextProtocol/ProgressNotificationValue.cs Outdated
Comment thread src/ModelContextProtocol/Protocol/Types/ProgressNotificationParams.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServerExtensions.cs Outdated
Copy link
Copy Markdown
Contributor

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working to improve this area.

@stephentoub stephentoub changed the title Progress-tokens Extend progress notification support Mar 31, 2025
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread src/ModelContextProtocol/Client/McpClient.cs
Comment thread src/ModelContextProtocol/Client/McpClient.cs Outdated
Comment thread src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated
Comment thread src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated
Comment thread src/ModelContextProtocol/Client/McpClientExtensions.cs
Comment thread src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated
Comment thread src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated
Comment thread src/ModelContextProtocol/Protocol/Types/ListPromptsRequestParams.cs
Comment thread src/ModelContextProtocol/Server/McpServerExtensions.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
Comment thread src/ModelContextProtocol/TokenProgress.cs Outdated
Comment thread src/ModelContextProtocol/TokenProgress.cs Outdated
Comment thread src/ModelContextProtocol/Client/McpClient.cs Outdated
Comment thread src/ModelContextProtocol/ClientTokenProgress.cs Outdated
Comment thread src/ModelContextProtocol/Server/McpServer.cs Outdated
@stephentoub
Copy link
Copy Markdown
Contributor

Thanks for working on this. I'm going to push a few changes to your branch, if that's ok.

@stephentoub
Copy link
Copy Markdown
Contributor

@Tyler-R-Kendrick, can you please hold off on pushing changes? I was about to merge based on what I'd pushed.

@stephentoub stephentoub merged commit 25bcb44 into modelcontextprotocol:main Apr 1, 2025
16 checks passed
@jeffhandley jeffhandley added the breaking-change This issue or PR introduces a breaking change label Feb 20, 2026
@jeffhandley
Copy link
Copy Markdown
Contributor

Adding the breaking-change label retroactively during release notes revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This issue or PR introduces a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants